295 Commits

Author SHA1 Message Date
Alberto Sottile
8aa05910eb Restore comment 2020-10-17 16:54:56 +02:00
Alberto Sottile
9b5a87157c Add start background image 2020-10-17 16:52:27 +02:00
Alberto Sottile
0154f8a873 cleanup 2020-10-17 16:27:36 +02:00
Alberto Sottile
03ef29390f Ädd support for IINA 2020-10-17 16:06:55 +02:00
et0h
16e33a4eef Tweak VLC messages and make them appear again 2020-09-22 11:48:57 +01:00
Etoh
dd8c864d98
Use Twisted for VLC communication (#353)
* Port VLCPlayer from asyncore/asynchat to Twisted

Rationale: asyncore/asynchat are deprecated since Python 3.6 and
are going to be removed from the standard library from Python 3.10.
It is unclear if these libraries will be picked up by maintainers
and independently published on PyPI. At the moment, we are working
on replacing them, in this commit with Twisted LineReceiver.

Known issues: does not work with GUI. There is a conflict with
qt5reactor -> "QSocketNotifier: Can only be used with threads
started with QThread".

* Fix QSocketNotifier issue with qt5reactor

Sending the call to transport.write wrapped in a
self.reactor.callFromThread instead of directly does the trick.
Include also fixes to allow correct quit of VLC and Syncplay when
either one is closed.

Known issues: there is a noticeable lag (~ 1 second) between the
start of Syncplay MainWindow and the start of VLC.

* Re-add try/except to VLC

* Bring back missing try

Co-authored-by: Alberto Sottile <alby128@gmail.com>
2020-09-20 13:45:23 +01:00
et0h
a02ddccf6b Always update VLC intf 2020-09-19 15:46:40 +01:00
et0h
9a10730e54 Add warning about erroneous VLC seeks (#354) 2020-09-19 14:50:10 +01:00
et0h
f7ca631e08 Allow = sign in value of command line options (#333) 2020-09-17 20:57:29 +01:00
Denis
bf4bea65c3
MPV: Add possibility to control which socket to use (#320)
Co-authored-by: Denis Fomin <dfomin@retechlabs.com>
2020-09-13 14:38:24 +01:00
Borislav Draganov
be92ff8b6d
Fixed MPC crashes when trying to open YouTube videos with emojis (#328)
* Fixed crashes when trying to open YouTube videos with emojis
2020-08-06 13:12:49 +01:00
ChiyoOsaka
7c9bd596b5
fix typo in error message (#323) 2020-06-10 23:13:06 +01:00
Etoh
89ce72d6cb
mpv: Preserve playback state when opening/closing a file 2020-05-27 18:33:07 +01:00
et0h
f8b8032ef6 Re-work handling of sync on join and playlist change (#280) 2020-05-23 16:55:22 +01:00
et0h
4dbf57e626 Fix seamless playlist advancement for music (#302) 2020-05-17 19:41:36 +01:00
et0h
5df3046287 Improve mpv error handling and display 'mpv-failed-advice' if load fails 2020-05-16 12:44:14 +01:00
Etoh
793e55ddbc
Move to JSON IPC API for mpv using iwaltons3's library (#261) (#310)
* Separate mpv from mplayer, increase min mpv ver to >= 0.17, refactor

* Further separation of mpv from mplayer

* Fix reference to isASCII

* Add iwalton3's Python MPV JSONIPC library (Apache 2.0)

* Move to JSON IPC API for mpv using iwaltons3's library (#261)

* Add empty init in Python MPV JSONIPC to make py2exe happy

* Use managed version of Python MPV JSONIPC to improve initialisation reliability

* Set mpv min version to >=0.29.0 to ensure compatibility

* Allow mpv >=0.23.0 based on daniel-123's tests

* Update mpv compatibility message

* Revert to old OSC compat message

* Removed mpv option that's no longer used afer switching to IPC.

* Update python-mpv-jsonipc to v1.1.11

* Use python-mpv-jsonipc's mpv quit handler

* Shorten mpv paused/position update message

Co-authored-by: daniel-123 <wrobel.dan@gmail.com>
2020-05-15 19:23:57 +01:00
Etoh
ff6a6ad5a5
Remove VLC --data-path to hopefully fix #301 & #302
Following suggestion from @bobismijnnaam in #301
2020-05-02 15:51:15 +01:00
et0h
4765fa452c Seamless advancement and auto-looping for music (mpv) 2019-08-17 16:33:01 +01:00
et0h
0f284e7329 Make mpv code compatible with mpvnet 2019-08-07 22:26:22 +01:00
et0h
187c8d87fc Add initial mpv.net support 2019-08-06 00:17:19 +01:00
Alberto Sottile
b334dd5e77 Do not ask to press enter from CLI after quitting mpv
Fixes: #238
2019-06-18 18:49:54 +02:00
Alberto Sottile
a9172f9fa6 Support for Snap VLC on Linux
Add the snap VLC path to the discovery list and automatically copy
our lua script in the correct path for snap installations.

Fixes: #222
2019-05-20 11:26:35 +02:00
et0h
7862c27d54 Initial support for VLC Portable (#235) 2019-05-19 20:59:04 +01:00
albertosottile
ff6bb74b49 Use dictionaries to get constant values for different OS 2019-05-14 16:00:22 +02:00
Etoh
5a9e2cde23
Don't identify mpv SMPlayer as mplayer (#234) 2019-04-16 20:52:46 +01:00
Alberto Sottile
c07206c189 Run mpv subprocess with a system PYTHONPATH env on macOS.
youtube-dl relies on system python to run on macOS, but system
python cannot be executed in a subprocess created from the frozen
python3 executable. This makes youtube-dl unusable from frozen
versions of Syncplay on macOS. So, the environment of the mpv
subprocess is modified with system PYTHONPATH, allowing the
execution of /usr/bin/python (and hence, of youtube-dl)
from within the subprocess in frozen executables.

Fixes: #228
2019-03-14 18:40:33 +01:00
Alberto Sottile
e1af902f7c VLC: hopefully fixes issue #213 2019-02-10 16:26:18 +01:00
Etoh
b781f62ed4 Ensure sycnplay.lua is user-writable 2019-02-10 12:26:01 +00:00
Etoh
a7fab29536 Create syncplay.lua intf directory if needed 2019-02-10 12:01:48 +00:00
Etoh
d8ebb50da7 Only copy syncplay.lua when needed 2019-02-09 17:58:26 +00:00
Etoh
99954ad4f4 Automatically copy syncplay.lua to VLC user intf directory 2019-02-02 01:21:56 +00:00
Daniel Ahn
2d143aefca Final Spacing changes for PR 2018-07-24 09:05:49 -07:00
xNinjaKittyx
3d35d2e02d Revert a typo and an equality check 2018-07-23 14:57:29 -07:00
xNinjaKittyx
d59afb8f2f Revert any changes to tri logic 2018-07-23 14:41:10 -07:00
Daniel Ahn
ac4da59479 Revert "Revert "Code Syntax Refactoring""
This reverts commit 51fba3722f653156eca30d45cb07846fb725a777.
2018-07-23 14:12:09 -07:00
Alberto Sottile
51fba3722f
Revert "Code Syntax Refactoring" 2018-07-23 22:32:47 +02:00
Daniel Ahn
f39461b331 Forgot the and statement 2018-07-21 10:43:18 -07:00
Daniel Ahn
1aa50a8422 Address comments 2018-07-21 10:41:00 -07:00
Daniel Ahn
63c0573ab2 Reverted most code back to == False. Future code should consider using is False if possible. 2018-07-21 03:20:34 -07:00
Daniel Ahn
292215dd22 Fixed some typos 2018-07-20 14:04:01 -07:00
Daniel Ahn
f01de206d8 fix formattings 2018-07-20 12:12:55 -07:00
albertosottile
ce2c37623a Detect portable versions of MPC-HC, MPC-BE and VLC 2018-06-15 11:17:35 +02:00
Alberto Sottile
5cb490f089 Fix VLC error when HTTPS URL contains square brackets (#187) 2018-06-09 17:08:11 +02:00
Alberto Sottile
fe224c0316 Fixes mpv support 2018-04-27 00:30:58 +02:00
Alberto Sottile
4fb771a450 Add preliminary support of PyInstaller on AppVeyor 2018-04-27 00:30:58 +02:00
Alberto Sottile
111976faf9 Adapt mplayer/mpv protocols to Python 3.x 2018-04-25 15:42:19 +02:00
albertosottile
2a1a291f3f Add Travis support 2018-04-24 20:31:48 +02:00
albertosottile
99e5e1ac0f Fixes open file from Syncplay to VLC 2018-04-24 15:59:54 +02:00
Alberto Sottile
b827a57cab 2to3 conversion and initial VLC support 2018-04-24 00:44:19 +02:00