From 2cc2b9e72aa1368069f65acfcd794643e2c10605 Mon Sep 17 00:00:00 2001 From: Uriziel Date: Tue, 1 Jan 2013 13:37:45 +0100 Subject: [PATCH] Some refactoring --- syncplay/ui/ConfigurationGetter.py | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/syncplay/ui/ConfigurationGetter.py b/syncplay/ui/ConfigurationGetter.py index aab7977..3599f52 100644 --- a/syncplay/ui/ConfigurationGetter.py +++ b/syncplay/ui/ConfigurationGetter.py @@ -181,6 +181,13 @@ class ConfigurationGetter(object): elif(GuiConfiguration): return GuiConfiguration(self._config).getProcessedConfiguration() + def __wasOptionChanged(self, parser, section, option): + if (parser.has_option(section, option)): + if (parser.get(section, option) != str(self._config[option])): + return True + else: + return True + def _saveConfig(self, iniPath): changed = False if(self._config['noStore']): @@ -188,14 +195,11 @@ class ConfigurationGetter(object): parser = SafeConfigParser() parser.read(iniPath) for section, options in self._iniStructure.items(): - if(not parser.has_section(section)): #TODO: refactor me + if(not parser.has_section(section)): parser.add_section(section) changed = True for option in options: - if(parser.has_option(section, option)): - if(parser.get(section, option) != str(self._config[option])): - changed = True - else: + if(self.__wasOptionChanged(parser, section, option)): changed = True parser.set(section, option, str(self._config[option])) if(changed):