From 3668e77a75c1212978772ad72b39fafe32fff229 Mon Sep 17 00:00:00 2001 From: Calum Lind Date: Tue, 2 May 2017 12:28:43 +0100 Subject: [PATCH] [GTKUI] Fix column sort state not saved in Thinclient mode * In torrentview.stop the listview is cleared however this meant in thinclient mode that listview sort details are empty and overwrites existing data when save_state is then called in torrentview.shutdown. --- deluge/ui/gtkui/torrentview.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/deluge/ui/gtkui/torrentview.py b/deluge/ui/gtkui/torrentview.py index 44796178c..97e579593 100644 --- a/deluge/ui/gtkui/torrentview.py +++ b/deluge/ui/gtkui/torrentview.py @@ -364,7 +364,6 @@ class TorrentView(ListView, component.Component): def stop(self): """Stops the torrentview""" - # We need to clear the liststore client.deregister_event_handler('TorrentStateChangedEvent', self.on_torrentstatechanged_event) client.deregister_event_handler('TorrentAddedEvent', self.on_torrentadded_event) client.deregister_event_handler('TorrentRemovedEvent', self.on_torrentremoved_event) @@ -374,6 +373,10 @@ class TorrentView(ListView, component.Component): if self.treeview.get_selection(): self.treeview.get_selection().unselect_all() + + # Save column state before clearing liststore + # so column sort details are correctly saved. + self.save_state() self.liststore.clear() self.prev_status = {} self.filter = None @@ -381,7 +384,7 @@ class TorrentView(ListView, component.Component): def shutdown(self): """Called when GtkUi is exiting""" - self.save_state() + pass def save_state(self): """